fix: Don't allow alerts without an ID to be dismissed

This commit is contained in:
2025-09-11 15:07:19 +10:00
parent eb6306bb83
commit 7fc19a7f19

View File

@@ -74,6 +74,7 @@ def index():
alerts = get_alerts(account) alerts = get_alerts(account)
for alert in alerts: for alert in alerts:
output_html = alert['output'] output_html = alert['output']
if 'id' in alert:
# Add a dismiss button # Add a dismiss button
output_html += f"&nbsp<a href='/dismiss/{alert['id']}' class='btn btn-secondary btn-sm' style='margin:none;'>Dismiss</a>" output_html += f"&nbsp<a href='/dismiss/{alert['id']}' class='btn btn-secondary btn-sm' style='margin:none;'>Dismiss</a>"
plugins += render_template('components/dashboard-alert.html', name=alert['name'], output=output_html) plugins += render_template('components/dashboard-alert.html', name=alert['name'], output=output_html)
@@ -1920,7 +1921,7 @@ def get_alerts(account:str) -> list:
logger.info("New version available") logger.info("New version available")
alerts.append({ alerts.append({
"name": "Update Available", "name": "Update Available",
"output": f"A new version of FireWallet is available. <a href='https://git.woodburn.au/nathanwoodburn/firewalletbrowser/compare/{commit}...{branch}' target='_blank'>Changelog</a>." "output": f"A new version of FireWallet is available. <a href='https://git.woodburn.au/nathanwoodburn/firewalletbrowser/compare/{commit}...{branch}' target='_blank'>Changelog</a>"
}) })